Built by Maven

PMD Results

The following document contains the results of PMD 7.14.0.

Violations By Priority

Priority 3

org/forgerock/audit/AuditServiceImpl.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 16–543

org/forgerock/audit/events/AccessAuditEventBuilder.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 121

org/forgerock/audit/events/EventTopicsMetaDataBuilder.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'configStream': resource specifications are implicitly final 147

org/forgerock/audit/events/handlers/writers/RotatableWriter.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 151–153
CollapsibleIfStatements This if statement could be combined with its parent 225–227

org/forgerock/audit/events/handlers/writers/TextWriter.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'Stream': the class is declared in an interface type 59

org/forgerock/audit/filter/FilterChainBuilder.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 70–72

org/forgerock/audit/rotation/FixedTimeRotationPolicy.java

Rule Violation Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 31

org/forgerock/audit/secure/KeyStoreHandler.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStore': the method is declared in an interface type 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'setStore': the method is declared in an interface type 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPassword': the method is declared in an interface type 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLocation': the method is declared in an interface type 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'getType': the method is declared in an interface type 62
UnnecessaryModifier Unnecessary modifier 'public' on method 'store': the method is declared in an interface type 70

org/forgerock/audit/util/DateUtil.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 186–188

org/forgerock/audit/util/JsonValueUtils.java

Rule Violation Line
UnnecessaryReturn Unnecessary return statement 303

Priority 4

org/forgerock/audit/events/handlers/writers/RotatableWriter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TimeUnit': 'MILLISECONDS' is already in scope because it is imported in this file 374
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TimeUnit': 'MILLISECONDS' is already in scope because it is imported in this file 375
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TimeUnit': 'MILLISECONDS' is already in scope because it is imported in this file 376

org/forgerock/audit/secure/KeyStoreSecureStorage.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'SIGNATURE_ALGORITHM' is already in scope because it is declared in an enclosing type 95
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'SIGNATURE_ALGORITHM' is already in scope because it is declared in an enclosing type 104
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_KEY' is already in scope because it is declared in an enclosing type 127
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_INITIAL_KEY' is already in scope because it is declared in an enclosing type 132
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_SIGNATURE' is already in scope because it is declared in an enclosing type 137
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_KEY' is already in scope because it is declared in an enclosing type 148
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_INITIAL_KEY' is already in scope because it is declared in an enclosing type 154

Files

org/forgerock/audit/AuditServiceImpl.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 16–543

org/forgerock/audit/events/AccessAuditEventBuilder.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 121

org/forgerock/audit/events/EventTopicsMetaDataBuilder.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'configStream': resource specifications are implicitly final 3 147

org/forgerock/audit/events/handlers/writers/RotatableWriter.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 151–153
CollapsibleIfStatements This if statement could be combined with its parent 3 225–227
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TimeUnit': 'MILLISECONDS' is already in scope because it is imported in this file 4 374
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TimeUnit': 'MILLISECONDS' is already in scope because it is imported in this file 4 375
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TimeUnit': 'MILLISECONDS' is already in scope because it is imported in this file 4 376

org/forgerock/audit/events/handlers/writers/TextWriter.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on class 'Stream': the class is declared in an interface type 3 59

org/forgerock/audit/filter/FilterChainBuilder.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 70–72

org/forgerock/audit/rotation/FixedTimeRotationPolicy.java

Rule Violation Priority Line
UnusedPrivateField Avoid unused private fields such as 'logger'. 3 31

org/forgerock/audit/secure/KeyStoreHandler.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'getStore': the method is declared in an interface type 3 31
UnnecessaryModifier Unnecessary modifier 'public' on method 'setStore': the method is declared in an interface type 3 41
UnnecessaryModifier Unnecessary modifier 'public' on method 'getPassword': the method is declared in an interface type 3 48
UnnecessaryModifier Unnecessary modifier 'public' on method 'getLocation': the method is declared in an interface type 3 55
UnnecessaryModifier Unnecessary modifier 'public' on method 'getType': the method is declared in an interface type 3 62
UnnecessaryModifier Unnecessary modifier 'public' on method 'store': the method is declared in an interface type 3 70

org/forgerock/audit/secure/KeyStoreSecureStorage.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'SIGNATURE_ALGORITHM' is already in scope because it is declared in an enclosing type 4 95
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'SIGNATURE_ALGORITHM' is already in scope because it is declared in an enclosing type 4 104
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_KEY' is already in scope because it is declared in an enclosing type 4 127
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_INITIAL_KEY' is already in scope because it is declared in an enclosing type 4 132
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_SIGNATURE' is already in scope because it is declared in an enclosing type 4 137
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_KEY' is already in scope because it is declared in an enclosing type 4 148
UnnecessaryFullyQualifiedName Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_INITIAL_KEY' is already in scope because it is declared in an enclosing type 4 154

org/forgerock/audit/util/DateUtil.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 186–188

org/forgerock/audit/util/JsonValueUtils.java

Rule Violation Priority Line
UnnecessaryReturn Unnecessary return statement 3 303