PMD Results

The following document contains the results of PMD 7.14.0.

Violations By Priority

Priority 3

org/forgerock/http/header/ContentLengthHeader.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 5961

org/forgerock/http/header/HeaderUtil.java

Rule Violation Line
EmptyControlStatement Empty if statement 218222

org/forgerock/http/io/BranchingStreamWrapper.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 199201

org/forgerock/http/io/FileBuffer.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 122124

org/forgerock/http/protocol/Cookie.java

Rule Violation Line
SimplifiedTernary This conditional expression can be simplified with || or && 172
SimplifiedTernary This conditional expression can be simplified with || or && 221

org/forgerock/http/protocol/Entity.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 17488

org/forgerock/http/protocol/Request.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 8486

org/forgerock/http/protocol/Response.java

Rule Violation Line
UnnecessarySemicolon Unnecessary semicolon 148

org/forgerock/http/routing/RouteMatchers.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 286288

org/forgerock/http/routing/UriRouteMatcher.java

Rule Violation Line
EmptyControlStatement Empty else statement 217219

org/forgerock/http/spi/Loader.java

Rule Violation Line
UnnecessarySemicolon Unnecessary semicolon 41

org/forgerock/http/util/Uris.java

Rule Violation Line
JumbledIncrementer Avoid modifying an outer loop incrementer in an inner loop for update expression 411428

org/forgerock/services/routing/AbstractRouter.java

Rule Violation Line
CollapsibleIfStatements This if statement could be combined with its parent 269271

Priority 4

org/forgerock/http/header/ContentEncodingHeader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'join' is already in scope 128

org/forgerock/http/header/ContentTypeHeader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'split' is already in scope 57
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'parseParameters' is already in scope 61

org/forgerock/http/header/CookieHeader.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'split' is already in scope 48
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'parseParameter' is already in scope 49
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'quote' is already in scope 178
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'quote' is already in scope 180
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'quote' is already in scope 183
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'quote' is already in scope 186

org/forgerock/http/io/BranchingStreamWrapper.java

Rule Violation Line
UselessParentheses Useless parentheses. 88

org/forgerock/http/io/ByteArrayBranchingStream.java

Rule Violation Line
UselessParentheses Useless parentheses. 61

org/forgerock/http/routing/UriRouteMatcher.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RoutingMode': 'EQUALS' is already in scope because it is imported in this file 314

org/forgerock/http/swagger/SwaggerApiProducer.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.util.Paths': 'addLeadingSlash' is already in scope 259

org/forgerock/http/swagger/SwaggerUtils.java

Rule Violation Line
UnnecessaryImport Unused import 'java.util.Map' 21
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.PathItem' 25
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.media.Schema' 27
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.parameters.Parameter' 28
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.responses.ApiResponse' 29
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.security.SecurityScheme' 30

org/forgerock/http/util/Json.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Json': 'PREFERRED_LOCALES_ATTRIBUTE' is already in scope because it is declared in an enclosing type 299

org/forgerock/http/util/Paths.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Paths': 'urlDecode' is already in scope 85

Files

org/forgerock/http/header/ContentEncodingHeader.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'join' is already in scope 4 128

org/forgerock/http/header/ContentLengthHeader.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 5961

org/forgerock/http/header/ContentTypeHeader.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'split' is already in scope 4 57
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'parseParameters' is already in scope 4 61

org/forgerock/http/header/CookieHeader.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'split' is already in scope 4 48
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'parseParameter' is already in scope 4 49
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'quote' is already in scope 4 178
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'quote' is already in scope 4 180
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'quote' is already in scope 4 183
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HeaderUtil': 'quote' is already in scope 4 186

org/forgerock/http/header/HeaderUtil.java

Rule Violation Priority Line
EmptyControlStatement Empty if statement 3 218222

org/forgerock/http/io/BranchingStreamWrapper.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 88
EmptyCatchBlock Avoid empty catch blocks 3 199201

org/forgerock/http/io/ByteArrayBranchingStream.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 61

org/forgerock/http/io/FileBuffer.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 122124

org/forgerock/http/protocol/Cookie.java

Rule Violation Priority Line
SimplifiedTernary This conditional expression can be simplified with || or && 3 172
SimplifiedTernary This conditional expression can be simplified with || or && 3 221

org/forgerock/http/protocol/Entity.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 17488

org/forgerock/http/protocol/Request.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 8486

org/forgerock/http/protocol/Response.java

Rule Violation Priority Line
UnnecessarySemicolon Unnecessary semicolon 3 148

org/forgerock/http/routing/RouteMatchers.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 286288

org/forgerock/http/routing/UriRouteMatcher.java

Rule Violation Priority Line
EmptyControlStatement Empty else statement 3 217219
UnnecessaryFullyQualifiedName Unnecessary qualifier 'RoutingMode': 'EQUALS' is already in scope because it is imported in this file 4 314

org/forgerock/http/spi/Loader.java

Rule Violation Priority Line
UnnecessarySemicolon Unnecessary semicolon 3 41

org/forgerock/http/swagger/SwaggerApiProducer.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.util.Paths': 'addLeadingSlash' is already in scope 4 259

org/forgerock/http/swagger/SwaggerUtils.java

Rule Violation Priority Line
UnnecessaryImport Unused import 'java.util.Map' 4 21
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.PathItem' 4 25
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.media.Schema' 4 27
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.parameters.Parameter' 4 28
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.responses.ApiResponse' 4 29
UnnecessaryImport Unused import 'io.swagger.v3.oas.models.security.SecurityScheme' 4 30

org/forgerock/http/util/Json.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Json': 'PREFERRED_LOCALES_ATTRIBUTE' is already in scope because it is declared in an enclosing type 4 299

org/forgerock/http/util/Paths.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Paths': 'urlDecode' is already in scope 4 85

org/forgerock/http/util/Uris.java

Rule Violation Priority Line
JumbledIncrementer Avoid modifying an outer loop incrementer in an inner loop for update expression 3 411428

org/forgerock/services/routing/AbstractRouter.java

Rule Violation Priority Line
CollapsibleIfStatements This if statement could be combined with its parent 3 269271