PMD Results

The following document contains the results of PMD 7.14.0.

Violations By Priority

Priority 3

org/forgerock/json/resource/http/CrestAdapter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 17478

org/forgerock/json/resource/http/HttpAdapter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 16936
EmptyControlStatement Empty if statement 548552
EmptyControlStatement Empty if statement 621625
CollapsibleIfStatements This if statement could be combined with its parent 691693

org/forgerock/json/resource/http/HttpUtils.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 17964
EmptyCatchBlock Avoid empty catch blocks 588591

org/forgerock/json/resource/http/RequestRunner.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 17550
UnnecessaryModifier Unnecessary modifier 'final' on method 'handleError': the method is already in a final class 130
UnnecessaryModifier Unnecessary modifier 'final' on method 'handleResult': the method is already in a final class 137
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitActionRequest': the method is already in a final class 148
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitCreateRequest': the method is already in a final class 182
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitDeleteRequest': the method is already in a final class 229
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitPatchRequest': the method is already in a final class 244
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitQueryRequest': the method is already in a final class 259
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitReadRequest': the method is already in a final class 339
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitUpdateRequest': the method is already in a final class 354
UnusedFormalParameter Avoid unused method parameters such as 'e'. 369

Priority 4

org/forgerock/json/resource/http/CrestAdapter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 253
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 274
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 351
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 368

org/forgerock/json/resource/http/HttpUtils.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 288
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 293
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'METHOD_POST' is already in scope because it is declared in an enclosing type 639
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type 640
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type 641
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 684

org/forgerock/json/resource/http/RequestRunner.java

Rule Violation Line
UselessParentheses Useless parentheses. 125127

Files

org/forgerock/json/resource/http/CrestAdapter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 17478
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 4 253
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 4 274
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 4 351
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 4 368

org/forgerock/json/resource/http/HttpAdapter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 16936
EmptyControlStatement Empty if statement 3 548552
EmptyControlStatement Empty if statement 3 621625
CollapsibleIfStatements This if statement could be combined with its parent 3 691693

org/forgerock/json/resource/http/HttpUtils.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 17964
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 4 288
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 4 293
EmptyCatchBlock Avoid empty catch blocks 3 588591
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'METHOD_POST' is already in scope because it is declared in an enclosing type 4 639
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type 4 640
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type 4 641
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 4 684

org/forgerock/json/resource/http/RequestRunner.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 17550
UselessParentheses Useless parentheses. 4 125127
UnnecessaryModifier Unnecessary modifier 'final' on method 'handleError': the method is already in a final class 3 130
UnnecessaryModifier Unnecessary modifier 'final' on method 'handleResult': the method is already in a final class 3 137
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitActionRequest': the method is already in a final class 3 148
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitCreateRequest': the method is already in a final class 3 182
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitDeleteRequest': the method is already in a final class 3 229
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitPatchRequest': the method is already in a final class 3 244
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitQueryRequest': the method is already in a final class 3 259
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitReadRequest': the method is already in a final class 3 339
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitUpdateRequest': the method is already in a final class 3 354
UnusedFormalParameter Avoid unused method parameters such as 'e'. 3 369