PMD Results

The following document contains the results of PMD 7.14.0.

Violations By Priority

Priority 3

org/forgerock/json/resource/http/CrestAdapter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 17478

org/forgerock/json/resource/http/HttpAdapter.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 17900
EmptyControlStatement Empty if statement 352356
EmptyControlStatement Empty if statement 520524
EmptyControlStatement Empty if statement 590594
CollapsibleIfStatements This if statement could be combined with its parent 656658

org/forgerock/json/resource/http/HttpUtils.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 17951
EmptyCatchBlock Avoid empty catch blocks 586589

org/forgerock/json/resource/http/RequestRunner.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 17557
UnnecessaryModifier Unnecessary modifier 'final' on method 'handleError': the method is already in a final class 129
UnnecessaryModifier Unnecessary modifier 'final' on method 'handleResult': the method is already in a final class 136
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitActionRequest': the method is already in a final class 147
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitCreateRequest': the method is already in a final class 183
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitDeleteRequest': the method is already in a final class 232
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitPatchRequest': the method is already in a final class 247
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitQueryRequest': the method is already in a final class 262
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitReadRequest': the method is already in a final class 344
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitUpdateRequest': the method is already in a final class 359
UnusedFormalParameter Avoid unused method parameters such as 'e'. 374

Priority 4

org/forgerock/json/resource/http/CrestAdapter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 253
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 274
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 351
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 368

org/forgerock/json/resource/http/HttpUtils.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 285
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 290
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'METHOD_POST' is already in scope because it is declared in an enclosing type 637
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type 638
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type 639
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 678
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 684

org/forgerock/json/resource/http/RequestRunner.java

Rule Violation Line
UselessParentheses Useless parentheses. 124126

Files

org/forgerock/json/resource/http/CrestAdapter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 17478
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 4 253
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 4 274
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 4 351
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Status': 'OK' is already in scope because it is imported in this file 4 368

org/forgerock/json/resource/http/HttpAdapter.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 17900
EmptyControlStatement Empty if statement 3 352356
EmptyControlStatement Empty if statement 3 520524
EmptyControlStatement Empty if statement 3 590594
CollapsibleIfStatements This if statement could be combined with its parent 3 656658

org/forgerock/json/resource/http/HttpUtils.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 17951
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 4 285
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 4 290
EmptyCatchBlock Avoid empty catch blocks 3 586589
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'METHOD_POST' is already in scope because it is declared in an enclosing type 4 637
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type 4 638
UnnecessaryFullyQualifiedName Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type 4 639
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 4 678
UnnecessaryFullyQualifiedName Unnecessary qualifier 'org.forgerock.http.protocol': 'Response' is already in scope because it is imported in this file 4 684

org/forgerock/json/resource/http/RequestRunner.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 17557
UselessParentheses Useless parentheses. 4 124126
UnnecessaryModifier Unnecessary modifier 'final' on method 'handleError': the method is already in a final class 3 129
UnnecessaryModifier Unnecessary modifier 'final' on method 'handleResult': the method is already in a final class 3 136
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitActionRequest': the method is already in a final class 3 147
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitCreateRequest': the method is already in a final class 3 183
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitDeleteRequest': the method is already in a final class 3 232
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitPatchRequest': the method is already in a final class 3 247
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitQueryRequest': the method is already in a final class 3 262
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitReadRequest': the method is already in a final class 3 344
UnnecessaryModifier Unnecessary modifier 'final' on method 'visitUpdateRequest': the method is already in a final class 3 359
UnusedFormalParameter Avoid unused method parameters such as 'e'. 3 374