PMD Results

The following document contains the results of PMD 7.14.0.

Violations By Priority

Priority 1

org/forgerock/util/LazyList.java

Rule Violation Line
DoubleCheckedLocking Double checked locking is not thread safe in Java. 61

org/forgerock/util/LazyMap.java

Rule Violation Line
DoubleCheckedLocking Double checked locking is not thread safe in Java. 62

Priority 3

org/forgerock/json/JsonValue.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 10191021

org/forgerock/json/RangeSet.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 104106

org/forgerock/util/SimpleHTTPClient.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 96

org/forgerock/util/i18n/LocalizableString.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 98100

org/forgerock/util/query/QueryFilter.java

Rule Violation Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 221

org/forgerock/util/query/QueryFilterParser.java

Rule Violation Line
EmptyControlStatement Empty for statement 382384

org/forgerock/util/thread/listener/ShutdownListener.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'shutdown': the method is declared in an interface type 28

org/forgerock/util/thread/listener/ShutdownPriority.java

Rule Violation Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ShutdownPriority(int)': enum constructors are implicitly private 50

org/forgerock/util/time/Duration.java

Rule Violation Line
TooManyStaticImports Too many static imports may lead to messy code 17415

org/forgerock/util/xml/XMLUtils.java

Rule Violation Line
EmptyCatchBlock Avoid empty catch blocks 91
EmptyCatchBlock Avoid empty catch blocks 122

Priority 4

org/forgerock/json/JsonPatch.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'JsonPatch': 'VALUE_PTR' is already in scope because it is declared in an enclosing type 68
UnnecessaryFullyQualifiedName Unnecessary qualifier 'JsonPatch': 'VALUE_PTR' is already in scope because it is declared in an enclosing type 69

org/forgerock/json/JsonValue.java

Rule Violation Line
UselessParentheses Useless parentheses. 193
UselessParentheses Useless parentheses. 379
UselessParentheses Useless parentheses. 379
UselessParentheses Useless parentheses. 392
UselessParentheses Useless parentheses. 405
UselessParentheses Useless parentheses. 540
UselessParentheses Useless parentheses. 553
UselessParentheses Useless parentheses. 553
UselessParentheses Useless parentheses. 639
UselessParentheses Useless parentheses. 639
UselessParentheses Useless parentheses. 651
UselessParentheses Useless parentheses. 651
UselessParentheses Useless parentheses. 746
UselessParentheses Useless parentheses. 859
UselessParentheses Useless parentheses. 888
UselessParentheses Useless parentheses. 897
UselessParentheses Useless parentheses. 906
UselessParentheses Useless parentheses. 915
UselessParentheses Useless parentheses. 933
UselessParentheses Useless parentheses. 942

org/forgerock/util/Pair.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Pair': 'of' is already in scope 49

org/forgerock/util/RangeSet.java

Rule Violation Line
UselessParentheses Useless parentheses. 90
UselessParentheses Useless parentheses. 91
UselessParentheses Useless parentheses. 93
UselessParentheses Useless parentheses. 101

org/forgerock/util/query/QueryFilter.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'equalTo' is already in scope 556
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'greaterThan' is already in scope 558
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'greaterThanOrEqualTo' is already in scope 560
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'lessThan' is already in scope 562
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'lessThanOrEqualTo' is already in scope 564
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'contains' is already in scope 566
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'startsWith' is already in scope 568

org/forgerock/util/time/Duration.java

Rule Violation Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TimeUnit': 'DAYS' is already in scope because it is imported in this file 276

Files

org/forgerock/json/JsonPatch.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'JsonPatch': 'VALUE_PTR' is already in scope because it is declared in an enclosing type 4 68
UnnecessaryFullyQualifiedName Unnecessary qualifier 'JsonPatch': 'VALUE_PTR' is already in scope because it is declared in an enclosing type 4 69

org/forgerock/json/JsonValue.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 193
UselessParentheses Useless parentheses. 4 379
UselessParentheses Useless parentheses. 4 379
UselessParentheses Useless parentheses. 4 392
UselessParentheses Useless parentheses. 4 405
UselessParentheses Useless parentheses. 4 540
UselessParentheses Useless parentheses. 4 553
UselessParentheses Useless parentheses. 4 553
UselessParentheses Useless parentheses. 4 639
UselessParentheses Useless parentheses. 4 639
UselessParentheses Useless parentheses. 4 651
UselessParentheses Useless parentheses. 4 651
UselessParentheses Useless parentheses. 4 746
UselessParentheses Useless parentheses. 4 859
UselessParentheses Useless parentheses. 4 888
UselessParentheses Useless parentheses. 4 897
UselessParentheses Useless parentheses. 4 906
UselessParentheses Useless parentheses. 4 915
UselessParentheses Useless parentheses. 4 933
UselessParentheses Useless parentheses. 4 942
EmptyCatchBlock Avoid empty catch blocks 3 10191021

org/forgerock/json/RangeSet.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 104106

org/forgerock/util/LazyList.java

Rule Violation Priority Line
DoubleCheckedLocking Double checked locking is not thread safe in Java. 1 61

org/forgerock/util/LazyMap.java

Rule Violation Priority Line
DoubleCheckedLocking Double checked locking is not thread safe in Java. 1 62

org/forgerock/util/Pair.java

Rule Violation Priority Line
UnnecessaryFullyQualifiedName Unnecessary qualifier 'Pair': 'of' is already in scope 4 49

org/forgerock/util/RangeSet.java

Rule Violation Priority Line
UselessParentheses Useless parentheses. 4 90
UselessParentheses Useless parentheses. 4 91
UselessParentheses Useless parentheses. 4 93
UselessParentheses Useless parentheses. 4 101

org/forgerock/util/SimpleHTTPClient.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final 3 96

org/forgerock/util/i18n/LocalizableString.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 98100

org/forgerock/util/query/QueryFilter.java

Rule Violation Priority Line
OverrideBothEqualsAndHashcode Ensure you override both equals() and hashCode() 3 221
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'equalTo' is already in scope 4 556
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'greaterThan' is already in scope 4 558
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'greaterThanOrEqualTo' is already in scope 4 560
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'lessThan' is already in scope 4 562
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'lessThanOrEqualTo' is already in scope 4 564
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'contains' is already in scope 4 566
UnnecessaryFullyQualifiedName Unnecessary qualifier 'QueryFilter': 'startsWith' is already in scope 4 568

org/forgerock/util/query/QueryFilterParser.java

Rule Violation Priority Line
EmptyControlStatement Empty for statement 3 382384

org/forgerock/util/thread/listener/ShutdownListener.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'public' on method 'shutdown': the method is declared in an interface type 3 28

org/forgerock/util/thread/listener/ShutdownPriority.java

Rule Violation Priority Line
UnnecessaryModifier Unnecessary modifier 'private' on constructor 'ShutdownPriority(int)': enum constructors are implicitly private 3 50

org/forgerock/util/time/Duration.java

Rule Violation Priority Line
TooManyStaticImports Too many static imports may lead to messy code 3 17415
UnnecessaryFullyQualifiedName Unnecessary qualifier 'TimeUnit': 'DAYS' is already in scope because it is imported in this file 4 276

org/forgerock/util/xml/XMLUtils.java

Rule Violation Priority Line
EmptyCatchBlock Avoid empty catch blocks 3 91
EmptyCatchBlock Avoid empty catch blocks 3 122