PMD Results
The following document contains the results of PMD 7.14.0.
Violations By Priority
Priority 1
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/CsvAuditEventHandler.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/LazyList.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/LazyMap.java
Priority 2
Wren Security Commons Authn. - JASPI (JSR-196) JWT Session Module - org/forgerock/jaspi/modules/session/jwt/JwtSessionModule.java
Wren Security Commons Authn. - JASPI (JSR-196) OpenAM Session Module - org/forgerock/jaspi/modules/session/openam/OpenAMSessionModule.java
ForgeRock Doc Build Maven Plugin - org/forgerock/doc/maven/utils/PngUtils.java
Priority 3
Wren Security Commons Audit - Framework Core - org/forgerock/audit/AuditServiceImpl.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/events/AccessAuditEventBuilder.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/events/EventTopicsMetaDataBuilder.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'configStream': resource specifications are implicitly final |
147 |
Wren Security Commons Audit - Framework Core - org/forgerock/audit/events/handlers/writers/RotatableWriter.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/events/handlers/writers/TextWriter.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on class 'Stream': the class is declared in an interface type |
59 |
Wren Security Commons Audit - Framework Core - org/forgerock/audit/filter/FilterChainBuilder.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/rotation/FixedTimeRotationPolicy.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/secure/KeyStoreHandler.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getStore': the method is declared in an interface type |
31 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setStore': the method is declared in an interface type |
41 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getPassword': the method is declared in an interface type |
48 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getLocation': the method is declared in an interface type |
55 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getType': the method is declared in an interface type |
62 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'store': the method is declared in an interface type |
70 |
Wren Security Commons Audit - Framework Core - org/forgerock/audit/util/DateUtil.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/util/JsonValueUtils.java
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/CsvAuditEventHandler.java
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/CsvSecureMapReader.java
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/SecureCsvWriter.java
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/StandardCsvWriter.java
Wren Security Commons Audit - Elasticsearch Event Handler - org/forgerock/audit/handlers/elasticsearch/ElasticsearchAuditEventHandler.java
Wren Security Commons Audit - Elasticsearch Event Handler - org/forgerock/audit/handlers/elasticsearch/ElasticsearchQueryFilterVisitor.java
Wren Security Commons Audit - JDBC Event Handler - org/forgerock/audit/handlers/jdbc/BufferedJdbcAuditEventExecutor.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'preparedStatement': resource specifications are implicitly final |
192 |
Wren Security Commons Audit - JDBC Event Handler - org/forgerock/audit/handlers/jdbc/JdbcAuditEventExecutorImpl.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'preparedStatement': resource specifications are implicitly final |
57 |
Wren Security Commons Audit - JDBC Event Handler - org/forgerock/audit/handlers/jdbc/StringSqlQueryFilterVisitor.java
Wren Security Commons Audit - JMS Event Handler - org/forgerock/audit/handlers/jms/JmsAuditEventHandler.java
Wren Security Commons Audit - JSON Event Handler - org/forgerock/audit/handlers/json/JsonAuditEventHandler.java
Wren Security Commons Audit - JSON Event Handler - org/forgerock/audit/handlers/json/JsonFileWriter.java
Wren Security Commons Audit - Splunk Event Handler - org/forgerock/audit/handlers/splunk/SplunkAuditEventHandler.java
Wren Security Commons Audit - Syslog Event Handler - org/forgerock/audit/handlers/syslog/SyslogFormatter.java
Wren Security Commons Audit - JSON Support Library - org/forgerock/audit/json/AuditJsonConfig.java
Wren Security Commons Audit - Servlet Example - org/forgerock/audit/AuditHttpApplication.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'eventHandlersConfig': resource specifications are implicitly final |
70 |
Wren Security Commons Authn. - JASPI (JSR-196) Functional Tests - org/forgerock/caf/authn/test/runtime/GuiceModule.java
Wren Security Commons Authn. - JASPI (JSR-196) IWA Module - org/forgerock/jaspi/modules/iwa/wdsso/WDSSO.java
Wren Security Commons Authn. - JASPI (JSR-196) JWT Session Module - org/forgerock/caf/http/SetCookieSupport.java
Wren Security Commons Authn. - JASPI (JSR-196) JWT Session Module - org/forgerock/jaspi/modules/session/jwt/AbstractJwtSessionModule.java
Wren Security Commons Authn. - JASPI (JSR-196) JWT Session Module - org/forgerock/jaspi/modules/session/jwt/JwtSessionModule.java
Wren Security Commons Authn. - JASPI (JSR-196) OpenAM Session Module - org/forgerock/jaspi/modules/session/openam/OpenAMSessionModule.java
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/OpenIdConnectModule.java
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/helpers/SimpleHTTPClient.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final |
91 |
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/OpenIdResolver.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'KEY_ALIAS_KEY': the field is declared in an interface type |
41 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'ISSUER_KEY': the field is declared in an interface type |
46 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'CLIENT_SECRET_KEY': the field is declared in an interface type |
51 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'JWK': the field is declared in an interface type |
56 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'WELL_KNOWN_CONFIGURATION': the field is declared in an interface type |
61 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'KEYSTORE_LOCATION_KEY': the field is declared in an interface type |
66 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'KEYSTORE_TYPE_KEY': the field is declared in an interface type |
71 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'KEYSTORE_PASS_KEY': the field is declared in an interface type |
76 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'validateIdentity': the method is declared in an interface type |
84 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getIssuer': the method is declared in an interface type |
91 |
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/service/OpenIdResolverService.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getResolverForIssuer': the method is declared in an interface type |
53 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureResolverWithKey': the method is declared in an interface type |
66 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureResolverWithSecret': the method is declared in an interface type |
78 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureResolverWithJWK': the method is declared in an interface type |
90 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureResolverWithWellKnownOpenIdConfiguration': the method is declared in an interface type |
101 |
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/service/OpenIdResolverServiceConfigurator.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureService': the method is declared in an interface type |
40 |
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/service/OpenIdResolverServiceImpl.java
Wren Security Commons Authn. - JASPI (JSR-196) Runtime - org/forgerock/caf/authentication/framework/AggregateAuthContext.java
Wren Security Commons Authn. - JASPI (JSR-196) Runtime - org/forgerock/caf/authentication/framework/AuthenticationFramework.java
Wren Security Commons Authn. - JASPI (JSR-196) Runtime - org/forgerock/caf/authentication/framework/SessionAuthContext.java
Wren Security Commons Authz. - OAuth2 Filter Module - org/forgerock/authz/modules/oauth2/OAuth2CrestAuthorizationModule.java
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/BatchingBloomFilter.java
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/BloomFilters.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'static' on enum 'NeverExpires': nested enums are implicitly static |
49 |
Wren Security Commons Bloom Filters - Monitoring - org/forgerock/bloomfilter/monitoring/BloomFilterMonitor.java
ForgeRock Doc Build Maven Plugin - org/forgerock/doc/maven/AbstractDocbkxMojo.java
ForgeRock Doc Build Maven Plugin - org/forgerock/doc/maven/PreProcessMojo.java
ForgeRock Doc Build Maven Plugin - org/forgerock/doc/maven/post/NoOp.java
ForgeRock Doc Build Maven Plugin - org/forgerock/doc/maven/utils/PngUtils.java
XCite Maven Plugin - org/forgerock/maven/plugins/xcite/XCiteMojo.java
Wren Security Guice Core - org/forgerock/guice/core/InjectorConfiguration.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'InjectorConfiguration()': enum constructors are implicitly private |
62 |
Wren Security Guice Core - org/forgerock/guice/core/InjectorHolder.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'InjectorHolder()': enum constructors are implicitly private |
53 |
Wren Security Guice Core - org/forgerock/guice/core/internal/commons/lang/reflect/MemberUtils.java
Wren Security Commons HTTP - CHF Bindings Test Utilities - org/forgerock/http/bindings/BindingTest.java
Rule |
Violation |
Line |
TooManyStaticImports |
Too many static imports may lead to messy code |
17–396 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'handler': resource specifications are implicitly final |
176 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'handler': resource specifications are implicitly final |
196 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'handler': resource specifications are implicitly final |
223 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'handler': resource specifications are implicitly final |
250 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'httpClientHandler': resource specifications are implicitly final |
294 |
Wren Security Commons HTTP - Apache Async HttpClient integration - org/forgerock/http/apache/async/AsyncHttpClientProvider.java
Wren Security Commons HTTP - Apache HttpClient integration - org/forgerock/http/apache/sync/SyncHttpClientProvider.java
Wren Security Commons HTTP - Client Test Utilities - org/forgerock/http/handler/HttpClientHandlerTest.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/header/ContentLengthHeader.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/header/HeaderUtil.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/io/BranchingStreamWrapper.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/io/FileBuffer.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/protocol/Cookie.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/protocol/Entity.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/protocol/Request.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/protocol/Response.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/routing/RouteMatchers.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/routing/UriRouteMatcher.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/spi/Loader.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/swagger/SwaggerApiProducer.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/util/Uris.java
Rule |
Violation |
Line |
JumbledIncrementer |
Avoid modifying an outer loop incrementer in an inner loop for update expression |
411–428 |
Wren Security Commons HTTP - Core Library - org/forgerock/services/routing/AbstractRouter.java
Wren Security Commons HTTP - OpenAPI Descriptor Example Module - org/forgerock/http/example/DescribedOauth2Endpoint.java
Wren Security Commons HTTP - Grizzly Integration Library - org/forgerock/http/grizzly/HandlerAdapter.java
Wren Security Commons HTTP - OAuth 2.0 Resource Server Support - org/forgerock/http/oauth2/resolver/OpenAmAccessTokenResolver.java
Wren Security Commons HTTP - Servlet integration library - org/forgerock/http/servlet/HttpFrameworkServlet.java
Wren Security I18N Maven Plugin - org/forgerock/i18n/maven/AbstractGenerateMessagesMojo.java
Wren Security I18N Maven Plugin - org/forgerock/i18n/maven/CleanMessagesMojo.java
Wren Security Commons JSON Crypto - Core Library - org/forgerock/json/crypto/JsonCrypto.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/helpers/FormatHelper.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/helpers/MaximumHelper.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/helpers/MinimumHelper.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/BooleanTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/IntegerTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/NumberTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/ObjectTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/SimpleValidator.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'validate': the method is declared in an interface type |
41 |
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/StringTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/UnionTypeValidator.java
Wren Security Commons JWT - org/forgerock/json/jose/jwe/JweAlgorithmType.java
Wren Security Commons JWT - org/forgerock/json/jose/jwe/handlers/encryption/AbstractRSAESPkcs1V15AesCbcHmacEncryptionHandler.java
Wren Security Commons JWT - org/forgerock/json/jose/jwe/handlers/encryption/RSAEncryptionHandler.java
Wren Security Commons JWT - org/forgerock/json/jose/jwk/KeyType.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'KeyType(String)': enum constructors are implicitly private |
49 |
Wren Security Commons JWT - org/forgerock/json/jose/jwk/KeyUse.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'KeyUse()': enum constructors are implicitly private |
38 |
Wren Security Commons JWT - org/forgerock/json/jose/jws/JwsAlgorithm.java
Wren Security Commons JWT - org/forgerock/json/jose/jws/JwtSecureHeader.java
Wren Security Commons JWT - org/forgerock/json/jose/utils/DerUtils.java
Wren Security Commons - API Descriptor - org/forgerock/api/CrestApiProducer.java
Wren Security Commons - API Descriptor - org/forgerock/api/commons/CommonsApi.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'Errors(int, String)': enum constructors are implicitly private |
176 |
Wren Security Commons - API Descriptor - org/forgerock/api/jackson/CrestPropertyDetailsSchemaFactoryWrapper.java
Wren Security Commons - API Descriptor - org/forgerock/api/jackson/CrestStringSchema.java
Wren Security Commons - API Descriptor - org/forgerock/api/markup/ApiDocGenerator.java
Wren Security Commons - API Descriptor - org/forgerock/api/markup/asciidoc/AsciiDoc.java
Wren Security Commons - API Descriptor - org/forgerock/api/models/Action.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'action': the method is already in a final class |
117 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/ApiDescription.java
Wren Security Commons - API Descriptor - org/forgerock/api/models/Create.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'create': the method is already in a final class |
77 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/Delete.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'delete': the method is already in a final class |
41 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/Patch.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'patch': the method is already in a final class |
85 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/Read.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'read': the method is already in a final class |
41 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/Update.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'update': the method is already in a final class |
41 |
Wren Security Commons - API Descriptor - org/forgerock/api/transform/OpenApiTransformer.java
Wren Security Commons - API Descriptor - org/forgerock/api/util/ValidationUtil.java
Rule |
Violation |
Line |
SimplifiedTernary |
This conditional expression can be simplified with || or && |
91 |
Wren Security Commons REST - JSON Resource Examples - org/forgerock/json/resource/examples/DynamicRealmDemo.java
Wren Security Commons REST - JSON Resource Examples - org/forgerock/json/resource/examples/ReadModifyWriteDemo.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'server': resource specifications are implicitly final |
47 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'connection': resource specifications are implicitly final |
48 |
Wren Security Commons REST - JSON Resource Examples - org/forgerock/json/resource/examples/VersionedResourcesDemo.java
Wren Security Commons REST - JSON Resource Examples - org/forgerock/json/resource/http/examples/CrestHttpApplication.java
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/CrestAdapter.java
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/HttpAdapter.java
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/HttpUtils.java
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/RequestRunner.java
Rule |
Violation |
Line |
TooManyStaticImports |
Too many static imports may lead to messy code |
17–550 |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'handleError': the method is already in a final class |
130 |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'handleResult': the method is already in a final class |
137 |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'visitActionRequest': the method is already in a final class |
148 |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'visitCreateRequest': the method is already in a final class |
182 |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'visitDeleteRequest': the method is already in a final class |
229 |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'visitPatchRequest': the method is already in a final class |
244 |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'visitQueryRequest': the method is already in a final class |
259 |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'visitReadRequest': the method is already in a final class |
339 |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'visitUpdateRequest': the method is already in a final class |
354 |
UnusedFormalParameter |
Avoid unused method parameters such as 'e'. |
369 |
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/DescribableResourceHandler.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'api': the method is already in a final class |
63 |
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/MemoryBackend.java
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/Requests.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'addSortKey': the method is already in a final class |
460 |
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/Resources.java
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/Router.java
Wren Security Commons JSON Patch - Library - org/forgerock/security/keystore/KeystoreManagerException.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/AnonymousProcessService.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/ProcessContextImpl.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/UserUpdateService.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/crypto/FieldStorageScheme.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'hashField': the method is declared in an interface type |
31 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'fieldMatches': the method is declared in an interface type |
41 |
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/util/RequirementsBuilder.java
Wren Security Commons Self Service - Examples - org/forgerock/selfservice/example/ExampleEmailService.java
Wren Security Commons Self Service - Stages - org/forgerock/selfservice/stages/email/VerifyEmailAccountStage.java
Wren Security Commons Self Service - Stages - org/forgerock/selfservice/stages/kba/SecurityAnswerDefinitionStage.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/json/JsonValue.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/json/RangeSet.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/SimpleHTTPClient.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final |
96 |
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/i18n/LocalizableString.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/query/QueryFilter.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/query/QueryFilterParser.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/thread/listener/ShutdownListener.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'shutdown': the method is declared in an interface type |
28 |
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/thread/listener/ShutdownPriority.java
Rule |
Violation |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'ShutdownPriority(int)': enum constructors are implicitly private |
50 |
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/time/Duration.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/xml/XMLUtils.java
Priority 4
Wren Security Commons Audit - Framework Core - org/forgerock/audit/events/handlers/writers/RotatableWriter.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/secure/KeyStoreSecureStorage.java
Rule |
Violation |
Line |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'SIGNATURE_ALGORITHM' is already in scope because it is declared in an enclosing type |
95 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'SIGNATURE_ALGORITHM' is already in scope because it is declared in an enclosing type |
104 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_KEY' is already in scope because it is declared in an enclosing type |
127 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_INITIAL_KEY' is already in scope because it is declared in an enclosing type |
132 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_SIGNATURE' is already in scope because it is declared in an enclosing type |
137 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_KEY' is already in scope because it is declared in an enclosing type |
148 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_INITIAL_KEY' is already in scope because it is declared in an enclosing type |
154 |
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/CsvAuditEventHandler.java
Wren Security Commons Audit - JSON Event Handler - org/forgerock/audit/handlers/json/JsonFileWriter.java
Wren Security Commons Authn. - JASPI (JSR-196) Functional Tests - org/forgerock/caf/authn/test/runtime/GuiceModule.java
Rule |
Violation |
Line |
UnnecessaryImport |
Unused static import 'org.forgerock.caf.authentication.framework.AuthenticationFilter.AuthenticationModuleBuilder' |
20 |
Wren Security Commons Authn. - JASPI (JSR-196) IWA Module - org/forgerock/jaspi/modules/iwa/wdsso/Base64.java
Wren Security Commons Authn. - JASPI (JSR-196) IWA Module - org/forgerock/jaspi/modules/iwa/wdsso/DerValue.java
Wren Security Commons Authn. - JASPI (JSR-196) IWA Module - org/forgerock/jaspi/modules/iwa/wdsso/WDSSO.java
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/OpenIdConnectModule.java
Rule |
Violation |
Line |
UnnecessaryImport |
Unused import 'jakarta.security.auth.message.AuthException' |
29 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'OpenIdConnectModule': 'HEADER_KEY' is already in scope because it is declared in an enclosing type |
140 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'OpenIdConnectModule': 'READ_TIMEOUT_KEY' is already in scope because it is declared in an enclosing type |
143 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'OpenIdConnectModule': 'CONNECTION_TIMEOUT_KEY' is already in scope because it is declared in an enclosing type |
144 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'OpenIdConnectModule': 'RESOLVERS_KEY' is already in scope because it is declared in an enclosing type |
162 |
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/BaseOpenIdResolver.java
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/service/OpenIdResolverServiceConfiguratorImpl.java
Wren Security Commons Authn. - JASPI (JSR-196) Runtime - org/forgerock/caf/authentication/framework/AuthenticationFramework.java
Rule |
Violation |
Line |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_AUTH_CONTEXT' is already in scope because it is declared in an enclosing type |
139 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_AUTH_CONTEXT' is already in scope because it is declared in an enclosing type |
168 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_AUTH_PRINCIPAL' is already in scope because it is declared in an enclosing type |
172 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_AUTH_CONTEXT' is already in scope because it is declared in an enclosing type |
173 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_REQUEST_ID' is already in scope because it is declared in an enclosing type |
188 |
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/AtomicBloomFilter.java
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/BloomFilterChain.java
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/BloomFilterStatistics.java
Wren Security Commons Bloom Filters - Monitoring - org/forgerock/bloomfilter/monitoring/BloomFilterMonitor.java
XCite Maven Plugin - org/forgerock/maven/plugins/xcite/Citation.java
XCite Maven Plugin - org/forgerock/maven/plugins/xcite/Resolver.java
XCite Maven Plugin - org/forgerock/maven/plugins/xcite/utils/StringUtils.java
Wren Security Guice Core - org/forgerock/guice/core/internal/commons/lang/reflect/ConstructorUtils.java
Wren Security Commons HTTP - JMH benchmarks - org/forgerock/http/serialization/JacksonJsonSerialization.java
Wren Security Commons HTTP - Apache Async HttpClient integration - org/forgerock/http/apache/async/CloseableBufferFactory.java
Rule |
Violation |
Line |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'java.nio': 'ByteBuffer' is already in scope because it is imported in this file |
58 |
Wren Security Commons HTTP - Core Library - org/forgerock/http/io/BranchingStreamWrapper.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/io/ByteArrayBranchingStream.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/util/Json.java
Rule |
Violation |
Line |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'Json': 'PREFERRED_LOCALES_ATTRIBUTE' is already in scope because it is declared in an enclosing type |
299 |
Wren Security Commons HTTP - Core Library - org/forgerock/http/util/Paths.java
Wren Security I18N Core - org/forgerock/i18n/LocalizableMessage.java
Wren Security I18N Maven Plugin - org/forgerock/i18n/maven/AbstractGenerateMessagesMojo.java
Wren Security I18N Maven Plugin - org/forgerock/i18n/maven/CleanMessagesMojo.java
Wren Security I18N SLF4J Support - org/forgerock/i18n/slf4j/LocalizedLogger.java
Wren Security Commons JSON Crypto - Core Library - org/forgerock/json/crypto/simple/SimpleDecryptor.java
Wren Security Commons JSON Crypto - Core Library - org/forgerock/json/crypto/simple/SimpleEncryptor.java
Wren Security Commons JSON Schema - Draft-04 Validator CLI - org/forgerock/json/schema/Main.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/ArrayTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/ObjectTypeValidator.java
Wren Security Commons JWT - org/forgerock/json/jose/jwe/EncryptionMethod.java
Wren Security Commons JWT - org/forgerock/json/jose/jwe/JweAlgorithm.java
Wren Security Commons JWT - org/forgerock/json/jose/jws/JwsAlgorithm.java
Wren Security Commons JWT - org/forgerock/json/jose/utils/DerUtils.java
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/HttpUtils.java
Rule |
Violation |
Line |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'HttpUtils': 'METHOD_POST' is already in scope because it is declared in an enclosing type |
639 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type |
640 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'HttpUtils': 'HEADER_X_HTTP_METHOD_OVERRIDE' is already in scope because it is declared in an enclosing type |
641 |
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/RequestRunner.java
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/AdviceWarning.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/config/ClassNameFallbackPropertyTypeResolver.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/util/Answers.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/json/JsonPatch.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/json/JsonValue.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/Pair.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/RangeSet.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/query/QueryFilter.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/time/Duration.java
Files
Wren Security Commons Audit - Framework Core - org/forgerock/audit/AuditServiceImpl.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/events/AccessAuditEventBuilder.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/events/EventTopicsMetaDataBuilder.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'configStream': resource specifications are implicitly final |
3 |
147 |
Wren Security Commons Audit - Framework Core - org/forgerock/audit/events/handlers/writers/RotatableWriter.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/events/handlers/writers/TextWriter.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on class 'Stream': the class is declared in an interface type |
3 |
59 |
Wren Security Commons Audit - Framework Core - org/forgerock/audit/filter/FilterChainBuilder.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/rotation/FixedTimeRotationPolicy.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/secure/KeyStoreHandler.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getStore': the method is declared in an interface type |
3 |
31 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'setStore': the method is declared in an interface type |
3 |
41 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getPassword': the method is declared in an interface type |
3 |
48 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getLocation': the method is declared in an interface type |
3 |
55 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getType': the method is declared in an interface type |
3 |
62 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'store': the method is declared in an interface type |
3 |
70 |
Wren Security Commons Audit - Framework Core - org/forgerock/audit/secure/KeyStoreSecureStorage.java
Rule |
Violation |
Priority |
Line |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'SIGNATURE_ALGORITHM' is already in scope because it is declared in an enclosing type |
4 |
95 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'SIGNATURE_ALGORITHM' is already in scope because it is declared in an enclosing type |
4 |
104 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_KEY' is already in scope because it is declared in an enclosing type |
4 |
127 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_INITIAL_KEY' is already in scope because it is declared in an enclosing type |
4 |
132 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_SIGNATURE' is already in scope because it is declared in an enclosing type |
4 |
137 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_CURRENT_KEY' is already in scope because it is declared in an enclosing type |
4 |
148 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'KeyStoreSecureStorage': 'ENTRY_INITIAL_KEY' is already in scope because it is declared in an enclosing type |
4 |
154 |
Wren Security Commons Audit - Framework Core - org/forgerock/audit/util/DateUtil.java
Wren Security Commons Audit - Framework Core - org/forgerock/audit/util/JsonValueUtils.java
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/CsvAuditEventHandler.java
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/CsvSecureMapReader.java
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/SecureCsvWriter.java
Wren Security Commons Audit - CSV Event Handler - org/forgerock/audit/handlers/csv/StandardCsvWriter.java
Wren Security Commons Audit - Elasticsearch Event Handler - org/forgerock/audit/handlers/elasticsearch/ElasticsearchAuditEventHandler.java
Wren Security Commons Audit - Elasticsearch Event Handler - org/forgerock/audit/handlers/elasticsearch/ElasticsearchQueryFilterVisitor.java
Wren Security Commons Audit - JDBC Event Handler - org/forgerock/audit/handlers/jdbc/BufferedJdbcAuditEventExecutor.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'preparedStatement': resource specifications are implicitly final |
3 |
192 |
Wren Security Commons Audit - JDBC Event Handler - org/forgerock/audit/handlers/jdbc/JdbcAuditEventExecutorImpl.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'preparedStatement': resource specifications are implicitly final |
3 |
57 |
Wren Security Commons Audit - JDBC Event Handler - org/forgerock/audit/handlers/jdbc/StringSqlQueryFilterVisitor.java
Wren Security Commons Audit - JMS Event Handler - org/forgerock/audit/handlers/jms/JmsAuditEventHandler.java
Wren Security Commons Audit - JSON Event Handler - org/forgerock/audit/handlers/json/JsonAuditEventHandler.java
Rule |
Violation |
Priority |
Line |
TooManyStaticImports |
Too many static imports may lead to messy code |
3 |
17–226 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final |
3 |
136–137 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final |
3 |
163–164 |
Wren Security Commons Audit - JSON Event Handler - org/forgerock/audit/handlers/json/JsonFileWriter.java
Wren Security Commons Audit - Splunk Event Handler - org/forgerock/audit/handlers/splunk/SplunkAuditEventHandler.java
Wren Security Commons Audit - Syslog Event Handler - org/forgerock/audit/handlers/syslog/SyslogFormatter.java
Wren Security Commons Audit - JSON Support Library - org/forgerock/audit/json/AuditJsonConfig.java
Rule |
Violation |
Priority |
Line |
UnusedPrivateField |
Avoid unused private fields such as 'EVENTS_FIELD'. |
3 |
59 |
Wren Security Commons Audit - Servlet Example - org/forgerock/audit/AuditHttpApplication.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'eventHandlersConfig': resource specifications are implicitly final |
3 |
70 |
Wren Security Commons Authn. - JASPI (JSR-196) Functional Tests - org/forgerock/caf/authn/test/runtime/GuiceModule.java
Rule |
Violation |
Priority |
Line |
TooManyStaticImports |
Too many static imports may lead to messy code |
3 |
18–140 |
UnnecessaryImport |
Unused static import 'org.forgerock.caf.authentication.framework.AuthenticationFilter.AuthenticationModuleBuilder' |
4 |
20 |
Wren Security Commons Authn. - JASPI (JSR-196) IWA Module - org/forgerock/jaspi/modules/iwa/wdsso/Base64.java
Wren Security Commons Authn. - JASPI (JSR-196) IWA Module - org/forgerock/jaspi/modules/iwa/wdsso/DerValue.java
Wren Security Commons Authn. - JASPI (JSR-196) IWA Module - org/forgerock/jaspi/modules/iwa/wdsso/WDSSO.java
Wren Security Commons Authn. - JASPI (JSR-196) JWT Session Module - org/forgerock/caf/http/SetCookieSupport.java
Wren Security Commons Authn. - JASPI (JSR-196) JWT Session Module - org/forgerock/jaspi/modules/session/jwt/AbstractJwtSessionModule.java
Wren Security Commons Authn. - JASPI (JSR-196) JWT Session Module - org/forgerock/jaspi/modules/session/jwt/JwtSessionModule.java
Wren Security Commons Authn. - JASPI (JSR-196) OpenAM Session Module - org/forgerock/jaspi/modules/session/openam/OpenAMSessionModule.java
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/OpenIdConnectModule.java
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/helpers/SimpleHTTPClient.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final |
3 |
91 |
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/BaseOpenIdResolver.java
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/OpenIdResolver.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'KEY_ALIAS_KEY': the field is declared in an interface type |
3 |
41 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'ISSUER_KEY': the field is declared in an interface type |
3 |
46 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'CLIENT_SECRET_KEY': the field is declared in an interface type |
3 |
51 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'JWK': the field is declared in an interface type |
3 |
56 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'WELL_KNOWN_CONFIGURATION': the field is declared in an interface type |
3 |
61 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'KEYSTORE_LOCATION_KEY': the field is declared in an interface type |
3 |
66 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'KEYSTORE_TYPE_KEY': the field is declared in an interface type |
3 |
71 |
UnnecessaryModifier |
Unnecessary modifiers 'public static final' on field 'KEYSTORE_PASS_KEY': the field is declared in an interface type |
3 |
76 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'validateIdentity': the method is declared in an interface type |
3 |
84 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getIssuer': the method is declared in an interface type |
3 |
91 |
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/service/OpenIdResolverService.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'getResolverForIssuer': the method is declared in an interface type |
3 |
53 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureResolverWithKey': the method is declared in an interface type |
3 |
66 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureResolverWithSecret': the method is declared in an interface type |
3 |
78 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureResolverWithJWK': the method is declared in an interface type |
3 |
90 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureResolverWithWellKnownOpenIdConfiguration': the method is declared in an interface type |
3 |
101 |
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/service/OpenIdResolverServiceConfigurator.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'configureService': the method is declared in an interface type |
3 |
40 |
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/service/OpenIdResolverServiceConfiguratorImpl.java
Wren Security Commons Authn. - JASPI (JSR-196) OIDC Module - org/forgerock/jaspi/modules/openid/resolvers/service/OpenIdResolverServiceImpl.java
Wren Security Commons Authn. - JASPI (JSR-196) Runtime - org/forgerock/caf/authentication/framework/AggregateAuthContext.java
Wren Security Commons Authn. - JASPI (JSR-196) Runtime - org/forgerock/caf/authentication/framework/AuthenticationFramework.java
Rule |
Violation |
Priority |
Line |
TooManyStaticImports |
Too many static imports may lead to messy code |
3 |
18–275 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_AUTH_CONTEXT' is already in scope because it is declared in an enclosing type |
4 |
139 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_AUTH_CONTEXT' is already in scope because it is declared in an enclosing type |
4 |
168 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_AUTH_PRINCIPAL' is already in scope because it is declared in an enclosing type |
4 |
172 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_AUTH_CONTEXT' is already in scope because it is declared in an enclosing type |
4 |
173 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'AuthenticationFramework': 'ATTRIBUTE_REQUEST_ID' is already in scope because it is declared in an enclosing type |
4 |
188 |
Wren Security Commons Authn. - JASPI (JSR-196) Runtime - org/forgerock/caf/authentication/framework/SessionAuthContext.java
Wren Security Commons Authz. - OAuth2 Filter Module - org/forgerock/authz/modules/oauth2/OAuth2CrestAuthorizationModule.java
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/AtomicBloomFilter.java
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/BatchingBloomFilter.java
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/BloomFilterChain.java
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/BloomFilterStatistics.java
Wren Security Commons Bloom Filters - Core - org/forgerock/bloomfilter/BloomFilters.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'static' on enum 'NeverExpires': nested enums are implicitly static |
3 |
49 |
Wren Security Commons Bloom Filters - Monitoring - org/forgerock/bloomfilter/monitoring/BloomFilterMonitor.java
ForgeRock Doc Build Maven Plugin - org/forgerock/doc/maven/AbstractDocbkxMojo.java
ForgeRock Doc Build Maven Plugin - org/forgerock/doc/maven/PreProcessMojo.java
ForgeRock Doc Build Maven Plugin - org/forgerock/doc/maven/post/NoOp.java
ForgeRock Doc Build Maven Plugin - org/forgerock/doc/maven/utils/PngUtils.java
XCite Maven Plugin - org/forgerock/maven/plugins/xcite/Citation.java
XCite Maven Plugin - org/forgerock/maven/plugins/xcite/Resolver.java
XCite Maven Plugin - org/forgerock/maven/plugins/xcite/XCiteMojo.java
XCite Maven Plugin - org/forgerock/maven/plugins/xcite/utils/StringUtils.java
Wren Security Guice Core - org/forgerock/guice/core/InjectorConfiguration.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'InjectorConfiguration()': enum constructors are implicitly private |
3 |
62 |
Wren Security Guice Core - org/forgerock/guice/core/InjectorHolder.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'InjectorHolder()': enum constructors are implicitly private |
3 |
53 |
Wren Security Guice Core - org/forgerock/guice/core/internal/commons/lang/reflect/ConstructorUtils.java
Wren Security Guice Core - org/forgerock/guice/core/internal/commons/lang/reflect/MemberUtils.java
Wren Security Commons HTTP - CHF Bindings Test Utilities - org/forgerock/http/bindings/BindingTest.java
Rule |
Violation |
Priority |
Line |
TooManyStaticImports |
Too many static imports may lead to messy code |
3 |
17–396 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'handler': resource specifications are implicitly final |
3 |
176 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'handler': resource specifications are implicitly final |
3 |
196 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'handler': resource specifications are implicitly final |
3 |
223 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'handler': resource specifications are implicitly final |
3 |
250 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'httpClientHandler': resource specifications are implicitly final |
3 |
294 |
Wren Security Commons HTTP - JMH benchmarks - org/forgerock/http/serialization/JacksonJsonSerialization.java
Rule |
Violation |
Priority |
Line |
UnnecessaryImport |
Unused import 'org.openjdk.jmh.annotations.Fork' |
4 |
33 |
Wren Security Commons HTTP - Apache Async HttpClient integration - org/forgerock/http/apache/async/AsyncHttpClientProvider.java
Wren Security Commons HTTP - Apache Async HttpClient integration - org/forgerock/http/apache/async/CloseableBufferFactory.java
Rule |
Violation |
Priority |
Line |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'java.nio': 'ByteBuffer' is already in scope because it is imported in this file |
4 |
58 |
Wren Security Commons HTTP - Apache HttpClient integration - org/forgerock/http/apache/sync/SyncHttpClientProvider.java
Wren Security Commons HTTP - Client Test Utilities - org/forgerock/http/handler/HttpClientHandlerTest.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/header/ContentLengthHeader.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/header/HeaderUtil.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/io/BranchingStreamWrapper.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/io/ByteArrayBranchingStream.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/io/FileBuffer.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/protocol/Cookie.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/protocol/Entity.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/protocol/Request.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/protocol/Response.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/routing/RouteMatchers.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/routing/UriRouteMatcher.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/spi/Loader.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/swagger/SwaggerApiProducer.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/util/Json.java
Rule |
Violation |
Priority |
Line |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'Json': 'PREFERRED_LOCALES_ATTRIBUTE' is already in scope because it is declared in an enclosing type |
4 |
299 |
Wren Security Commons HTTP - Core Library - org/forgerock/http/util/Paths.java
Wren Security Commons HTTP - Core Library - org/forgerock/http/util/Uris.java
Rule |
Violation |
Priority |
Line |
JumbledIncrementer |
Avoid modifying an outer loop incrementer in an inner loop for update expression |
3 |
411–428 |
Wren Security Commons HTTP - Core Library - org/forgerock/services/routing/AbstractRouter.java
Wren Security Commons HTTP - OpenAPI Descriptor Example Module - org/forgerock/http/example/DescribedOauth2Endpoint.java
Wren Security Commons HTTP - Grizzly Integration Library - org/forgerock/http/grizzly/HandlerAdapter.java
Wren Security Commons HTTP - OAuth 2.0 Resource Server Support - org/forgerock/http/oauth2/resolver/OpenAmAccessTokenResolver.java
Wren Security Commons HTTP - Servlet integration library - org/forgerock/http/servlet/HttpFrameworkServlet.java
Wren Security I18N Core - org/forgerock/i18n/LocalizableMessage.java
Wren Security I18N Maven Plugin - org/forgerock/i18n/maven/AbstractGenerateMessagesMojo.java
Wren Security I18N Maven Plugin - org/forgerock/i18n/maven/CleanMessagesMojo.java
Wren Security I18N SLF4J Support - org/forgerock/i18n/slf4j/LocalizedLogger.java
Wren Security Commons JSON Crypto - Core Library - org/forgerock/json/crypto/JsonCrypto.java
Wren Security Commons JSON Crypto - Core Library - org/forgerock/json/crypto/simple/SimpleDecryptor.java
Wren Security Commons JSON Crypto - Core Library - org/forgerock/json/crypto/simple/SimpleEncryptor.java
Wren Security Commons JSON Schema - Draft-04 Validator CLI - org/forgerock/json/schema/Main.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/helpers/FormatHelper.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/helpers/MaximumHelper.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/helpers/MinimumHelper.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/ArrayTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/BooleanTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/IntegerTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/NumberTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/ObjectTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/SimpleValidator.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'validate': the method is declared in an interface type |
3 |
41 |
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/StringTypeValidator.java
Wren Security Commons JSON Schema - Draft-04 Validator - org/forgerock/json/schema/validator/validators/UnionTypeValidator.java
Wren Security Commons JWT - org/forgerock/json/jose/jwe/EncryptionMethod.java
Wren Security Commons JWT - org/forgerock/json/jose/jwe/JweAlgorithm.java
Wren Security Commons JWT - org/forgerock/json/jose/jwe/JweAlgorithmType.java
Wren Security Commons JWT - org/forgerock/json/jose/jwe/handlers/encryption/AbstractRSAESPkcs1V15AesCbcHmacEncryptionHandler.java
Rule |
Violation |
Priority |
Line |
UnusedFormalParameter |
Avoid unused constructor parameters such as 'signingManager'. |
3 |
46 |
Wren Security Commons JWT - org/forgerock/json/jose/jwe/handlers/encryption/RSAEncryptionHandler.java
Wren Security Commons JWT - org/forgerock/json/jose/jwk/KeyType.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'KeyType(String)': enum constructors are implicitly private |
3 |
49 |
Wren Security Commons JWT - org/forgerock/json/jose/jwk/KeyUse.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'KeyUse()': enum constructors are implicitly private |
3 |
38 |
Wren Security Commons JWT - org/forgerock/json/jose/jws/JwsAlgorithm.java
Wren Security Commons JWT - org/forgerock/json/jose/jws/JwtSecureHeader.java
Wren Security Commons JWT - org/forgerock/json/jose/utils/DerUtils.java
Wren Security Commons - API Descriptor - org/forgerock/api/CrestApiProducer.java
Wren Security Commons - API Descriptor - org/forgerock/api/commons/CommonsApi.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'Errors(int, String)': enum constructors are implicitly private |
3 |
176 |
Wren Security Commons - API Descriptor - org/forgerock/api/jackson/CrestPropertyDetailsSchemaFactoryWrapper.java
Wren Security Commons - API Descriptor - org/forgerock/api/jackson/CrestStringSchema.java
Wren Security Commons - API Descriptor - org/forgerock/api/markup/ApiDocGenerator.java
Wren Security Commons - API Descriptor - org/forgerock/api/markup/asciidoc/AsciiDoc.java
Wren Security Commons - API Descriptor - org/forgerock/api/models/Action.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'action': the method is already in a final class |
3 |
117 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/ApiDescription.java
Wren Security Commons - API Descriptor - org/forgerock/api/models/Create.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'create': the method is already in a final class |
3 |
77 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/Delete.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'delete': the method is already in a final class |
3 |
41 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/Patch.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'patch': the method is already in a final class |
3 |
85 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/Read.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'read': the method is already in a final class |
3 |
41 |
Wren Security Commons - API Descriptor - org/forgerock/api/models/Update.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'update': the method is already in a final class |
3 |
41 |
Wren Security Commons - API Descriptor - org/forgerock/api/transform/OpenApiTransformer.java
Wren Security Commons - API Descriptor - org/forgerock/api/util/ValidationUtil.java
Rule |
Violation |
Priority |
Line |
SimplifiedTernary |
This conditional expression can be simplified with || or && |
3 |
91 |
Wren Security Commons REST - JSON Resource Examples - org/forgerock/json/resource/examples/DynamicRealmDemo.java
Wren Security Commons REST - JSON Resource Examples - org/forgerock/json/resource/examples/ReadModifyWriteDemo.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'server': resource specifications are implicitly final |
3 |
47 |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'connection': resource specifications are implicitly final |
3 |
48 |
Wren Security Commons REST - JSON Resource Examples - org/forgerock/json/resource/examples/VersionedResourcesDemo.java
Wren Security Commons REST - JSON Resource Examples - org/forgerock/json/resource/http/examples/CrestHttpApplication.java
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/CrestAdapter.java
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/HttpAdapter.java
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/HttpUtils.java
Wren Security Commons REST - JSON Resource HTTP Binding - org/forgerock/json/resource/http/RequestRunner.java
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/AdviceWarning.java
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/DescribableResourceHandler.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'api': the method is already in a final class |
3 |
63 |
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/MemoryBackend.java
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/Requests.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on method 'addSortKey': the method is already in a final class |
3 |
460 |
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/Resources.java
Wren Security Commons REST - JSON Resource Core Library - org/forgerock/json/resource/Router.java
Wren Security Commons JSON Patch - Library - org/forgerock/security/keystore/KeystoreManagerException.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/AnonymousProcessService.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/ProcessContextImpl.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/UserUpdateService.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/config/ClassNameFallbackPropertyTypeResolver.java
Rule |
Violation |
Priority |
Line |
UnnecessaryImport |
Unused import 'com.fasterxml.jackson.databind.ObjectMapper' |
4 |
23 |
UnnecessaryImport |
Unused import 'com.fasterxml.jackson.databind.json.JsonMapper' |
4 |
25 |
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/crypto/FieldStorageScheme.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'hashField': the method is declared in an interface type |
3 |
31 |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'fieldMatches': the method is declared in an interface type |
3 |
41 |
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/util/Answers.java
Wren Security Commons Self Service - Core - org/forgerock/selfservice/core/util/RequirementsBuilder.java
Wren Security Commons Self Service - Examples - org/forgerock/selfservice/example/ExampleEmailService.java
Wren Security Commons Self Service - Stages - org/forgerock/selfservice/stages/email/VerifyEmailAccountStage.java
Wren Security Commons Self Service - Stages - org/forgerock/selfservice/stages/kba/SecurityAnswerDefinitionStage.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/json/JsonPatch.java
Rule |
Violation |
Priority |
Line |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'JsonPatch': 'VALUE_PTR' is already in scope because it is declared in an enclosing type |
4 |
68 |
UnnecessaryFullyQualifiedName |
Unnecessary qualifier 'JsonPatch': 'VALUE_PTR' is already in scope because it is declared in an enclosing type |
4 |
69 |
Wren Security Commons Utility Classes - Utility Library - org/forgerock/json/JsonValue.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/json/RangeSet.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/LazyList.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/LazyMap.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/Pair.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/RangeSet.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/SimpleHTTPClient.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'final' on resource specification 'reader': resource specifications are implicitly final |
3 |
96 |
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/i18n/LocalizableString.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/query/QueryFilter.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/query/QueryFilterParser.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/thread/listener/ShutdownListener.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'public' on method 'shutdown': the method is declared in an interface type |
3 |
28 |
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/thread/listener/ShutdownPriority.java
Rule |
Violation |
Priority |
Line |
UnnecessaryModifier |
Unnecessary modifier 'private' on constructor 'ShutdownPriority(int)': enum constructors are implicitly private |
3 |
50 |
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/time/Duration.java
Wren Security Commons Utility Classes - Utility Library - org/forgerock/util/xml/XMLUtils.java